fix: make replace no-op for empty search#22275
Open
nvphungdev wants to merge 1 commit into
Open
Conversation
github-actions
Bot
added
sqllogictest
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
replacewith an empty search string should be a no-op #22253.Rationale for this change
PostgreSQL treats
replace(str, '', replacement)as a no-op. DataFusion currently inserts the replacement before every character and at both ends, soreplace('abc', '', 'x')returnsxaxbxcxinstead ofabc.What changes are included in this PR?
replaceimplementation so an empty search substring returns the original input string unchanged.Are these changes tested?
Yes:
cargo fmt --allcargo test -p datafusion-functions string::replace::tests::test_functionscargo test -p datafusion-sqllogictest --test sqllogictests -- expr.slt:637cargo clippy --all-targets --all-features -- -D warningsgit diff --checkAre there any user-facing changes?
Yes.
replacenow matches PostgreSQL-compatible behavior for an empty search substring.